Skip to content

Ensure we're setting a project path explicitly

Ryan Ahearn requested to merge ensure-project-has-path into main

Changes proposed in this pull request:

  • project.path previously could be nil, which would cause gitlab to build the path from the name, this ensures that we always set it to either the passed path value or the "slug" key from the input map.

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, this value was always set after the fact anyway.

Merge request reports